feat(external-storage): Implement IPartialMountPoint #57497
Draft
+433
−104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
3 times, most recently
from
209115a to
67fcb93
Compare
icewind1991
reviewed
Jan 12, 2026
icewind1991
reviewed
Jan 12, 2026
icewind1991
reviewed
Jan 12, 2026
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
from
67fcb93 to
3ddc49b
Compare
artonge
reviewed
Jan 12, 2026
Comment on lines
+180
to
+200
| $userId = null; | ||
| $user = null; | ||
| foreach ($mountProviderArgs as $mountProviderArg) { | ||
| if ($userId === null) { | ||
| $user = $mountProviderArg->mountInfo->getUser(); | ||
| $userId = $user->getUID(); | ||
| } elseif ($userId !== $mountProviderArg->mountInfo->getUser()->getUID()) { | ||
| throw new \LogicException('Mounts must belong to the same user!'); | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
I was wondering if we shouldn't move that check:
server/lib/private/Files/Config/MountProviderCollection.php
Lines 91 to 116 in e83c890
Not sure why Salvatore didn't.
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
4 times, most recently
from
0db2c55 to
2dfcaf7
Compare
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
from
2dfcaf7 to
b384327
Compare
artonge
reviewed
Jan 15, 2026
| $builder->expr()->andX( // global mounts | ||
| $builder->expr()->eq('a.type', $builder->createNamedParameter(self::APPLICABLE_TYPE_GLOBAL, IQueryBuilder::PARAM_INT)), | ||
| $builder->expr()->isNull('a.value'), | ||
| $forChildren ? $builder->expr()->like('m.mount_point', $builder->createNamedParameter($this->connection->escapeLikeParameter($path) . '%', IQueryBuilder::PARAM_STR)) |
Contributor
There was a problem hiding this comment.
Salvatore used _% to target paths with at least one extra character. I am wondering if we should use /% to explicitly target paths that are under the provided path.
Contributor
There was a problem hiding this comment.
After discussion with Carl, /% needs to be carefully applied in case the path end with a /
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
2 times, most recently
from
d8882d1 to
35159bb
Compare
Signed-off-by: Carl Schwan <[email protected]>
CarlSchwan
force-pushed
the
carl/external-storage-ipartialmountpoint
branch
from
35159bb to
a359de3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
3. to review, feature component)stable32)